1.8.0 (#356)

* distributed option

* i18n, pause, etc

* fixes galore

* max buffer etc

* test override config

* maxgame

* visit

* contribute menu

* restore vars

* i18n

* actually start

* retry distr and errors

* pw eye / move speed

* cfg/no log

* shutdown fix

* shutdown fix

* download fix

* wut

* stats and desc

* esc fix

* Omit terminate queries from KataGoEngine.queries. (#353)

* press key h to clear current node analysis. (#352)

* clear current node all analysis

* add reset key binding

* reset all analysis off.

* code refactor

* code change according to review.

* remove useless variable

* code review changes

* clean up reset node

* oops

* Setup position feature (#354)

* go for zebras

* setup working!

* uhh

* tweak

* img

* fix i18n

* AEEEEEEEEEE and stop

* link in readme

* new game options for edit/new/setup (#357)

* new game options for edit/new/setup

* feedback

* fix

* ai thoughts

* no tristate cb

* branch fixing (#358)

* new game options for edit/new/setup

* feedback

* fix

* ai thoughts

* no tristate cb

* fix comma etc

* normal katago

* kata

* dll

* save window pos/size

* BAD comma

* new linux binary + allow default engine

* fix

* unused icon, build mac

* exe

* player new game fix

* fix i18n

* test test

* just print

* 한국어

* –활성화

* Add new Traditional Chinese translation (#362)

Improve some translations as well.

* cn (#363)

* cn

* rm old

* rm old

* informal you

* mo

* jp (#364)

* config and readme

* mo

* kgtraining

* fix score

* lower stddev a bit

* tweak weights

* 1.8 French Po (#365)

* fr and getattr fix

* -DBUILD_DISTRIBUTED=1

* openssl

* openssl

* openssl

* openssl

* config

* jp (num undos) (#366)

* clarify undo in en, po->mo

* fix player name

* new kata

* new kata

* Load game option save config (#367)

* in the load dialog,  "load fast analysis" and "rewind to the start" option ,save to config file

* in the load dialog,  "load fast analysis" and "rewind to the start" option ,save to config file

* default option

* remove useless override

* save check state when file dialog's submit event ,

* save config in callback

* readme

* active games

* de

* log games as json always

* black

* Russian localization for 1.8.0 (#375)

* ru

Co-authored-by: pdeblanc <peter@spaceandgames.com>
Co-authored-by: xiaoyifang <105986+xiaoyifang@users.noreply.github.com>
Co-authored-by: Liou, Guan-Cheng <Tony-Liou@users.noreply.github.com>
Co-authored-by: kaorahi <38910552+kaorahi@users.noreply.github.com>
Co-authored-by: Dontbtme <66470440+Dontbtme@users.noreply.github.com>
Co-authored-by: Alexander Kiselev <satoshi.yoda.register.264@gmail.com>

katrain/core/game_node.py

@@ -106,7 +106,12 @@ class GameNode(SGFNode):
         self.analysis = {"moves": {}, "root": None, "ownership": None, "policy": None, "completed": False}
 
     def sgf_properties(
-        self, save_comments_player=None, save_comments_class=None, eval_thresholds=None, save_analysis=False
+        self,
+        save_comments_player=None,
+        save_comments_class=None,
+        eval_thresholds=None,
+        save_analysis=False,
+        save_marks=False,
     ):
         properties = copy.copy(super().sgf_properties())
         note = self.note.strip()
@@ -126,17 +131,18 @@ class GameNode(SGFNode):
             and self.analysis_exists
             and (note or ((save_comments_player or {}).get(self.player, False) and show_class))
         ):
-            candidate_moves = self.parent.candidate_moves
-            top_x = Move.from_gtp(candidate_moves[0]["move"]).sgf(self.board_size)
-            best_sq = [
-                Move.from_gtp(d["move"]).sgf(self.board_size)
-                for d in candidate_moves
-                if d["pointsLost"] <= 0.5 and d["move"] != "pass" and d["order"] != 0
-            ]
-            if best_sq and "SQ" not in properties:
-                properties["SQ"] = best_sq
-            if top_x and "MA" not in properties:
-                properties["MA"] = [top_x]
+            if save_marks:
+                candidate_moves = self.parent.candidate_moves
+                top_x = Move.from_gtp(candidate_moves[0]["move"]).sgf(self.board_size)
+                best_sq = [
+                    Move.from_gtp(d["move"]).sgf(self.board_size)
+                    for d in candidate_moves
+                    if d["pointsLost"] <= 0.5 and d["move"] != "pass" and d["order"] != 0
+                ]
+                if best_sq and "SQ" not in properties:
+                    properties["SQ"] = best_sq
+                if top_x and "MA" not in properties:
+                    properties["MA"] = [top_x]
             comments.append(self.comment(sgf=True, interactive=False) + SGF_INTERNAL_COMMENTS_MARKER)
         if self.is_root:
             comments = [
@@ -286,9 +292,10 @@ class GameNode(SGFNode):
         single_move = self.move
         if single_move and self.parent:
             policy_ranking = self.parent.policy_ranking
-            for ix, (p, m) in enumerate(policy_ranking):
-                if m == single_move:
-                    return ix + 1, p, policy_ranking
+            if policy_ranking:
+                for ix, (p, m) in enumerate(policy_ranking):
+                    if m == single_move:
+                        return ix + 1, p, policy_ranking
         return None, 0.0, []
 
     def make_pv(self, player, pv, interactive):
@@ -301,7 +308,10 @@ class GameNode(SGFNode):
         single_move = self.move
         if not self.parent or not single_move:  # root
             if self.root:
-                return f"{i18n._('komi')}: {self.komi:.1f}\n{i18n._('ruleset')}: {i18n._(self.get_property('RU','Japanese').lower())}\n"
+                rules = self.get_property("RU", "Japanese")
+                if isinstance(rules, str):  # else katago dict
+                    rules = i18n._(rules.lower())
+                return f"{i18n._('komi')}: {self.komi:.1f}\n{i18n._('ruleset')}: {rules}\n"
             return ""
 
         text = i18n._("move").format(number=self.depth) + f": {single_move.player} {single_move.gtp()}\n"
@@ -319,7 +329,13 @@ class GameNode(SGFNode):
                             text += i18n._("Info:point loss").format(points_lost=points_lost) + "\n"
                         top_move = previous_top_move["move"]
                         score = self.format_score(previous_top_move["scoreLead"])
-                        text += i18n._("Info:top move").format(top_move=top_move, score=score) + "\n"
+                        text += (
+                            i18n._("Info:top move").format(
+                                top_move=top_move,
+                                score=score,
+                            )
+                            + "\n"
+                        )
                     else:
                         text += i18n._("Info:best move") + "\n"
                     if previous_top_move.get("pv") and (sgf or details):